Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1026723002: [Android WebView] Deflake new OnReceived*Error tests that simulate tap (Closed)

Created:
5 years, 9 months ago by mnaganov (inactive)
Modified:
5 years, 9 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Deflake new OnReceived*Error tests that simulate tap It seems that the first non-empty draw sometimes is missing the link that the test is supposed to "tap". Waiting for the pixel colour to actually change to the link colour stabilizes tests. BUG=456782 Committed: https://crrev.com/029257f2c1b944b483eada3e5f05373b11175bfb Cr-Commit-Position: refs/heads/master@{#321557}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
5 years, 9 months ago (2015-03-20 11:04:17 UTC) #2
Torne
lgtm
5 years, 9 months ago (2015-03-20 11:28:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026723002/1
5 years, 9 months ago (2015-03-20 11:29:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 12:12:03 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 12:12:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/029257f2c1b944b483eada3e5f05373b11175bfb
Cr-Commit-Position: refs/heads/master@{#321557}

Powered by Google App Engine
This is Rietveld 408576698