android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedHttpErrorTest.java - Issue 1026723002: [Android WebView] Deflake new OnReceived*Error tests that simulate tap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedHttpErrorTest.java

Issue 1026723002: [Android WebView] Deflake new OnReceived*Error tests that simulate tap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/util/CommonResources.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedHttpErrorTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedHttpErrorTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedHttpErrorTest.java

index 053ce5b44f24273ed67e24648da2b3fa11c3893e..ce6854a27f3bac5940b6d65a25e47c01cf52a632 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedHttpErrorTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedHttpErrorTest.java

@@ -129,7 +129,8 @@ public class ClientOnReceivedHttpErrorTest extends AwTestBase {

CommonResources.makeHtmlPageWithSimpleLinkTo(badUrl), null);

enableJavaScriptOnUiThread(mAwContents);

loadUrlAsync(mAwContents, pageWithLinkUrl);

- waitForVisualStateCallback(mAwContents);

+ waitForPixelColorAtCenterOfView(mAwContents,

+ mTestContainerView, CommonResources.LINK_COLOR);

TestAwContentsClient.OnReceivedHttpErrorHelper onReceivedHttpErrorHelper =

mContentsClient.getOnReceivedHttpErrorHelper();