Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: extensions/renderer/resources/guest_view/web_view/web_view_attributes.js

Issue 1026703004: Refactored extensionOptions to use the new guestViewAttributes module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resources/guest_view/web_view/web_view.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
diff --git a/extensions/renderer/resources/guest_view/web_view/web_view_attributes.js b/extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
index 3b666a24e54754e0db67326aede9717a782566f4..ce538fdc3df3c2ff51c44d006036eae868eed295 100644
--- a/extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
+++ b/extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
@@ -5,8 +5,8 @@
// This module implements the attributes of the <webview> tag.
var GuestViewAttributes = require('guestViewAttributes').GuestViewAttributes;
-var WebViewImpl = require('webView').WebViewImpl;
var WebViewConstants = require('webViewConstants').WebViewConstants;
+var WebViewImpl = require('webView').WebViewImpl;
var WebViewInternal = require('webViewInternal').WebViewInternal;
// -----------------------------------------------------------------------------
@@ -252,9 +252,7 @@ SrcAttribute.prototype.parse = function() {
// -----------------------------------------------------------------------------
// Sets up all of the webview attributes.
-WebViewImpl.prototype.setupWebViewAttributes = function() {
- this.attributes = {};
-
+WebViewImpl.prototype.setupAttributes = function() {
this.attributes[WebViewConstants.ATTRIBUTE_ALLOWSCALING] =
new AllowScalingAttribute(this);
this.attributes[WebViewConstants.ATTRIBUTE_ALLOWTRANSPARENCY] =
« no previous file with comments | « extensions/renderer/resources/guest_view/web_view/web_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698