Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: extensions/renderer/resources/guest_view/web_view/web_view.js

Issue 1026703004: Refactored extensionOptions to use the new guestViewAttributes module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/guest_view/web_view/web_view.js
diff --git a/extensions/renderer/resources/guest_view/web_view/web_view.js b/extensions/renderer/resources/guest_view/web_view/web_view.js
index c061c8387c3e4d403c7e4b7778551fc54b0cea04..1b40d156f2ef994b235fb4ed3f581d6d8aafa698 100644
--- a/extensions/renderer/resources/guest_view/web_view/web_view.js
+++ b/extensions/renderer/resources/guest_view/web_view/web_view.js
@@ -18,9 +18,7 @@ var WebViewInternal = require('webViewInternal').WebViewInternal;
function WebViewImpl(webviewElement) {
GuestViewContainer.call(this, webviewElement, 'webview');
- this.setupWebViewAttributes();
this.setupElementProperties();
-
new WebViewEvents(this, this.viewInstanceId);
}
@@ -98,17 +96,6 @@ WebViewImpl.prototype.setupElementProperties = function() {
});
};
-// This observer monitors mutations to attributes of the <webview>.
-WebViewImpl.prototype.handleAttributeMutation = function(
- attributeName, oldValue, newValue) {
- if (!this.attributes[attributeName]) {
- return;
- }
-
- // Let the changed attribute handle its own mutation;
- this.attributes[attributeName].maybeHandleMutation(oldValue, newValue);
-};
-
WebViewImpl.prototype.onSizeChanged = function(webViewEvent) {
var newWidth = webViewEvent.newWidth;
var newHeight = webViewEvent.newHeight;

Powered by Google App Engine
This is Rietveld 408576698