Issue 1026613002: Return the outermost embedder when returning the embedder web contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1026613002: Return the outermost embedder when returning the embedder web contents. (Closed)

Created:
5 years, 9 months ago by Sam McNally

Modified:
5 years, 9 months ago

Reviewers:
raymes

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@2311

Target Ref:
refs/pending/branch-heads/2311

Project:
chromium

Visibility:
Public.

More Reviews

Description

Return the outermost embedder when returning the embedder web contents. Currently, ChromeConstrainedWindowViewsClient::GetEmbedderWebContents returns the embedder WebContents of the GuestView if the initiator WebContents is in a GuestView. However, with OOP PDF, a mime handler view can be embedded in a webview that is embedded in an app window; in this case, the webview WebContents is returned instead of the app window WebContents. This CL changes GetEmbedderWebContents to return the outermost embedder WebContents. BUG=457672 Review URL: https://codereview.chromium.org/1012373002 Cr-Commit-Position: refs/heads/master@{#321248} (cherry picked from commit 7c0b1291c525a2b6aa3fe810fd69098952bc2d5f) TBR=raymes@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/75b3e545a3d51582a28c068e48d4b89aa10ade39

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	chrome/browser/ui/views/chrome_constrained_window_views_client.cc	View		1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Sam McNally

5 years, 9 months ago (2015-03-20 00:43:58 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
75b3e545a3d51582a28c068e48d4b89aa10ade39 (presubmit successful).

Expand Messages | Collapse Messages