Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1012373002: Return the outermost embedder when returning the embedder web contents. (Closed)

Created:
5 years, 9 months ago by Sam McNally
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return the outermost embedder when returning the embedder web contents. Currently, ChromeConstrainedWindowViewsClient::GetEmbedderWebContents returns the embedder WebContents of the GuestView if the initiator WebContents is in a GuestView. However, with OOP PDF, a mime handler view can be embedded in a webview that is embedded in an app window; in this case, the webview WebContents is returned instead of the app window WebContents. This CL changes GetEmbedderWebContents to return the outermost embedder WebContents. BUG=457672 Committed: https://crrev.com/7c0b1291c525a2b6aa3fe810fd69098952bc2d5f Cr-Commit-Position: refs/heads/master@{#321248}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/browser/ui/views/chrome_constrained_window_views_client.cc View 1 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sam McNally
5 years, 9 months ago (2015-03-18 06:20:41 UTC) #2
sky
LGTM https://codereview.chromium.org/1012373002/diff/1/chrome/browser/ui/views/chrome_constrained_window_views_client.cc File chrome/browser/ui/views/chrome_constrained_window_views_client.cc (right): https://codereview.chromium.org/1012373002/diff/1/chrome/browser/ui/views/chrome_constrained_window_views_client.cc#newcode24 chrome/browser/ui/views/chrome_constrained_window_views_client.cc:24: while (extensions::GuestViewBase* guest_view = This is worth a ...
5 years, 9 months ago (2015-03-18 15:00:36 UTC) #3
Sam McNally
https://codereview.chromium.org/1012373002/diff/1/chrome/browser/ui/views/chrome_constrained_window_views_client.cc File chrome/browser/ui/views/chrome_constrained_window_views_client.cc (right): https://codereview.chromium.org/1012373002/diff/1/chrome/browser/ui/views/chrome_constrained_window_views_client.cc#newcode24 chrome/browser/ui/views/chrome_constrained_window_views_client.cc:24: while (extensions::GuestViewBase* guest_view = On 2015/03/18 15:00:36, sky wrote: ...
5 years, 9 months ago (2015-03-18 22:40:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012373002/20001
5 years, 9 months ago (2015-03-18 22:41:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 00:26:46 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 00:27:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c0b1291c525a2b6aa3fe810fd69098952bc2d5f
Cr-Commit-Position: refs/heads/master@{#321248}

Powered by Google App Engine
This is Rietveld 408576698