Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1026553004: Reland "Now that the cq runs tests on rel, the compile-only bug should be dbg." (Closed)

Created:
5 years, 9 months ago by Nico
Modified:
5 years, 9 months ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Now that the cq runs tests on rel, the compile-only bug should be dbg." This was reverted because findbugs didn't work reliably. Now that it does, this can land again. The last revert was at https://codereview.chromium.org/947513002 BUG=456396 TBR=sergiyb@chromium.org Committed: https://crrev.com/518e158356e67db008dd1922f2a08e0ab0b73456 Cr-Commit-Position: refs/heads/master@{#322008}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/commit_queue/config.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 9 months ago (2015-03-24 15:29:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026553004/20001
5 years, 9 months ago (2015-03-24 15:30:15 UTC) #4
Sergiy Byelozyorov
lgtm
5 years, 9 months ago (2015-03-24 15:31:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 15:58:18 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 15:59:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/518e158356e67db008dd1922f2a08e0ab0b73456
Cr-Commit-Position: refs/heads/master@{#322008}

Powered by Google App Engine
This is Rietveld 408576698