Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 947513002: Revert of Revert of Revert of Now that the cq runs tests on rel, the compile-only bug should be dbg. (Closed)

Created:
5 years, 10 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
jam, Sergiy Byelozyorov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Revert of Now that the cq runs tests on rel, the compile-only bug should be dbg. (patchset #1 id:1 of https://codereview.chromium.org/941363002/) Reason for revert: `findbugs` is running and failing. Undo this again while I figure that out. Original issue's description: > Revert of Revert of Now that the cq runs tests on rel, the compile-only bug should be dbg. (patchset #1 id:1 of https://codereview.chromium.org/914023007/) > > Reason for revert: > The regular android dbg bots also do static buils, so trying this again. I'm watching the bot. > > Original issue's description: > > Revert of Now that the cq runs tests on rel, the compile-only bug should be dbg. (patchset #1 id:1 of https://codereview.chromium.org/937853002/) > > > > Reason for revert: > > Too many red builds on the dbg not, need to investigate tomorrow. Also, it does a static build for some reason. > > > > Original issue's description: > > > Now that the cq runs tests on rel, the compile-only bug should be dbg. > > > > > > Depends on https://codereview.chromium.org/913223007 > > > > > > BUG=456396 > > > TBR=sergiyb@chromium.org > > > > > > Committed: https://crrev.com/3d0efdf9afa56e55b8d8c62fd883a1992f35cf45 > > > Cr-Commit-Position: refs/heads/master@{#316998} > > > > TBR=jam@chromium.org,sergiyb@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=456396 > > > > Committed: https://crrev.com/f3a85349d2da16aa306f1fdc43ea3b5d21a9f956 > > Cr-Commit-Position: refs/heads/master@{#316999} > > TBR=jam@chromium.org,sergiyb@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=456396 > > Committed: https://crrev.com/89f83d5a826c0bfdee8a8cafea307e84d8958df3 > Cr-Commit-Position: refs/heads/master@{#317341} TBR=jam@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=456396 Committed: https://crrev.com/66e9039ed2d73cd7499fd84bad0ba909cbd9a61f Cr-Commit-Position: refs/heads/master@{#317356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/commit_queue/config.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of Revert of Revert of Now that the cq runs tests on rel, ...
5 years, 10 months ago (2015-02-20 18:33:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947513002/1
5 years, 10 months ago (2015-02-20 18:34:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 18:36:57 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/66e9039ed2d73cd7499fd84bad0ba909cbd9a61f Cr-Commit-Position: refs/heads/master@{#317356}
5 years, 10 months ago (2015-02-20 18:38:19 UTC) #4
Sergiy Byelozyorov
4 years, 9 months ago (2016-03-23 15:17:06 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698