components/autofill/content/renderer/autofill_agent.h - Issue 1026493002: Allow only a user gesture to trigger autofill popup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 1026493002: Allow only a user gesture to trigger autofill popup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not layout frame. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/autofill_agent.h

diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h

index 4ec475c20c66f39bded36d4e74287bee9add5b2d..39d65733e06522e911807cce1c71778d6da3c25a 100644

--- a/components/autofill/content/renderer/autofill_agent.h

+++ b/components/autofill/content/renderer/autofill_agent.h

@@ -252,9 +252,6 @@ class AutofillAgent : public content::RenderFrameObserver,

// currently editing? Used to keep track of state for metrics logging.

bool has_shown_autofill_popup_for_current_edit_;

- // If true we just set the node text so we shouldn't show the popup.

- bool did_set_node_text_;

// Whether or not to ignore text changes. Useful for when we're committing

// a composition when we are defocusing the WebView and we don't want to

// trigger an autofill popup to show.