Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: components/autofill/content/renderer/autofill_agent.h

Issue 1026493002: Allow only a user gesture to trigger autofill popup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not layout frame. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 // The form element currently requesting an interactive autocomplete. 245 // The form element currently requesting an interactive autocomplete.
246 blink::WebFormElement in_flight_request_form_; 246 blink::WebFormElement in_flight_request_form_;
247 247
248 // Was the query node autofilled prior to previewing the form? 248 // Was the query node autofilled prior to previewing the form?
249 bool was_query_node_autofilled_; 249 bool was_query_node_autofilled_;
250 250
251 // Have we already shown Autofill suggestions for the field the user is 251 // Have we already shown Autofill suggestions for the field the user is
252 // currently editing? Used to keep track of state for metrics logging. 252 // currently editing? Used to keep track of state for metrics logging.
253 bool has_shown_autofill_popup_for_current_edit_; 253 bool has_shown_autofill_popup_for_current_edit_;
254 254
255 // If true we just set the node text so we shouldn't show the popup.
256 bool did_set_node_text_;
257
258 // Whether or not to ignore text changes. Useful for when we're committing 255 // Whether or not to ignore text changes. Useful for when we're committing
259 // a composition when we are defocusing the WebView and we don't want to 256 // a composition when we are defocusing the WebView and we don't want to
260 // trigger an autofill popup to show. 257 // trigger an autofill popup to show.
261 bool ignore_text_changes_; 258 bool ignore_text_changes_;
262 259
263 // Whether the Autofill popup is possibly visible. This is tracked as a 260 // Whether the Autofill popup is possibly visible. This is tracked as a
264 // performance improvement, so that the IPC channel isn't flooded with 261 // performance improvement, so that the IPC channel isn't flooded with
265 // messages to close the Autofill popup when it can't possibly be showing. 262 // messages to close the Autofill popup when it can't possibly be showing.
266 bool is_popup_possibly_visible_; 263 bool is_popup_possibly_visible_;
267 264
268 base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_; 265 base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
269 266
270 DISALLOW_COPY_AND_ASSIGN(AutofillAgent); 267 DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
271 }; 268 };
272 269
273 } // namespace autofill 270 } // namespace autofill
274 271
275 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 272 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698