chrome/renderer/autofill/password_autofill_agent_browsertest.cc - Issue 1026493002: Allow only a user gesture to trigger autofill popup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_autofill_agent_browsertest.cc

Issue 1026493002: Allow only a user gesture to trigger autofill popup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable user gesture check for tests. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/autofill/password_autofill_agent_browsertest.cc

diff --git a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

index 7b310372848d9f2f916f9030edf7c41cdc5425e8..e50a87e13db90eb3b856b43c8046b86758800c5b 100644

--- a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

+++ b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

@@ -883,6 +883,8 @@ TEST_F(PasswordAutofillAgentTest, IframeNoFillTest) {

// test the autofill.

WebFrame* iframe = GetMainFrame()->findChildByName(kIframeName);

ASSERT_TRUE(iframe);

+ static_cast<AutofillAgent*>(iframe->toWebLocalFrame()->autofillClient())

+ ->DisableUserGestureCheckForTests();

Evan Stade 2015/03/23 22:07:12 This doesn't seem right to me. Instead of modifyin

SimulateOnFillPasswordFormForFrame(iframe, fill_data_);

« no previous file with comments | « no previous file | chrome/test/base/chrome_render_view_test.cc » ('j') | no next file with comments »