Allow only a user gesture to trigger autofill popup

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
@@ skipping 865 matching lines @@
   LoadHTML(page_html.c_str());
 
   // Set the expected form origin and action URLs.
   fill_data_.origin = GURL(origin);
   fill_data_.action = GURL(origin);
 
   // Retrieve the input elements from the iframe since that is where we want to
   // test the autofill.
   WebFrame* iframe = GetMainFrame()->findChildByName(kIframeName);
   ASSERT_TRUE(iframe);
+  static_cast<AutofillAgent*>(iframe->toWebLocalFrame()->autofillClient())
+      ->DisableUserGestureCheckForTests();

[Evan Stade, 2015/03/23 22:07:12]

This doesn't seem right to me. Instead of modifying production code execution
during tests (i.e. testing something that's not the real code), we should
simulate a user gesture. IOW, fix SimulateInputChangeForElement

 
   SimulateOnFillPasswordFormForFrame(iframe, fill_data_);
 
   WebDocument document = iframe->document();
 
   WebElement username_element = document.getElementById(kUsernameName);
   WebElement password_element = document.getElementById(kPasswordName);
   ASSERT_FALSE(username_element.isNull());
   ASSERT_FALSE(password_element.isNull());
 
@@ skipping 952 matching lines @@
 
   ClearUsernameAndPasswordFields();
 
   username_element_.setValue("foobar");
   SetElementReadOnly(username_element_, true);
 
   CheckTextFieldsState(std::string("foobar"), false, std::string(), false);
 }
 
 }  // namespace autofill