Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2845)

Unified Diff: content/test/mock_keyboard_driver_win.cc

Issue 1026493002: Allow only a user gesture to trigger autofill popup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not show autofill popup if desktop IME is composing. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/mock_keyboard_driver_win.cc
diff --git a/content/test/mock_keyboard_driver_win.cc b/content/test/mock_keyboard_driver_win.cc
index 3bac80077c8c1afcb53a266a3fc1be95bd92e781..4ecf11a2fe51b0aa75674e6501bb85fd4c535686 100644
--- a/content/test/mock_keyboard_driver_win.cc
+++ b/content/test/mock_keyboard_driver_win.cc
@@ -119,7 +119,7 @@ bool MockKeyboardDriverWin::SetLayout(int layout) {
return false;
}
-bool MockKeyboardDriverWin::SetModifiers(int modifiers) {
+void MockKeyboardDriverWin::SetModifiers(int modifiers) {
// Over-write the keyboard status with our modifier-key status.
// WebInputEventFactory::keyboardEvent() uses GetKeyState() to retrive
// modifier-key status. So, we update the modifier-key status with this
@@ -146,12 +146,10 @@ bool MockKeyboardDriverWin::SetModifiers(int modifiers) {
keyboard_states_[kModifierMasks[i].key_code] = kKeyDownMask;
}
SetKeyboardState(&keyboard_states_[0]);
-
- return true;
}
int MockKeyboardDriverWin::GetCharacters(int key_code,
- std::wstring* output) {
+ std::wstring* output) const {
// Retrieve Unicode characters composed from the input key-code and
// the mofifiers.
CHECK(output);
« content/renderer/render_widget.cc ('K') | « content/test/mock_keyboard_driver_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698