Allow only a user gesture to trigger autofill popup

content/renderer/render_widget.cc

Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 82e2b2b3f50de3220e0f956d3bfb59b35642d64f..1aab8b42fc06fd0573f5d5ab6d503e42ea25e637 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -1679,19 +1679,10 @@ void RenderWidget::OnImeSetComposition(
     int selection_start, int selection_end) {
   if (!ShouldHandleImeEvent())
     return;
-
-  bool is_user_gesture = false;
-#if defined(OS_ANDROID)
-  // Android keyboard goes into IME composition mode to suggest words as you
-  // type. Mark IME composition as a user gesture on Android to enable such
-  // features as autofill popup while in IME composition mode.
-  is_user_gesture = true;
-#endif
-
   ImeEventGuard guard(this);
-  if (!webwidget_->setUserGestureComposition(

[Evan Stade, 2015/04/16 13:58:59]

why can't I find the old function anywhere?

[please use gerrit instead, 2015/04/16 16:08:35]

That's a function that I was going to add, but decided to not add later on. This
patch is bad. I will re-upload a better one once I solve the 2 remaining issues:

1) Let autofill_agent know when compositing is going on. (hasCompoistion does
not do what we want yet.)

2) Simulate key presses on Mac.

+  if (!webwidget_->setComposition(
       text, WebVector<WebCompositionUnderline>(underlines),
-      selection_start, selection_end, is_user_gesture)) {
+      selection_start, selection_end)) {
     // If we failed to set the composition text, then we need to let the browser
     // process to cancel the input method's ongoing composition session, to make
     // sure we are in a consistent state.