Allow only a user gesture to trigger autofill popup

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 1661 matching lines @@
 void RenderWidget::OnCandidateWindowHidden() {
   webwidget_->didHideCandidateWindow();
 }
 
 void RenderWidget::OnImeSetComposition(
     const base::string16& text,
     const std::vector<WebCompositionUnderline>& underlines,
     int selection_start, int selection_end) {
   if (!ShouldHandleImeEvent())
     return;
-
-  bool is_user_gesture = false;
-#if defined(OS_ANDROID)
-  // Android keyboard goes into IME composition mode to suggest words as you
-  // type. Mark IME composition as a user gesture on Android to enable such
-  // features as autofill popup while in IME composition mode.
-  is_user_gesture = true;
-#endif
-
   ImeEventGuard guard(this);
-  if (!webwidget_->setUserGestureComposition(

[Evan Stade, 2015/04/16 13:58:59]

why can't I find the old function anywhere?

[please use gerrit instead, 2015/04/16 16:08:35]

That's a function that I was going to add, but decided to not add later on. This
patch is bad. I will re-upload a better one once I solve the 2 remaining issues:

1) Let autofill_agent know when compositing is going on. (hasCompoistion does
not do what we want yet.)

2) Simulate key presses on Mac.

+  if (!webwidget_->setComposition(
       text, WebVector<WebCompositionUnderline>(underlines),
-      selection_start, selection_end, is_user_gesture)) {
+      selection_start, selection_end)) {
     // If we failed to set the composition text, then we need to let the browser
     // process to cancel the input method's ongoing composition session, to make
     // sure we are in a consistent state.
     Send(new InputHostMsg_ImeCancelComposition(routing_id()));
   }
   UpdateCompositionInfo(true);
 }
 
 void RenderWidget::OnImeConfirmComposition(const base::string16& text,
                                            const gfx::Range& replacement_range,
@@ skipping 744 matching lines @@
 void RenderWidget::RegisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.AddObserver(frame);
 }
 
 void RenderWidget::UnregisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.RemoveObserver(frame);
 }
 #endif  // defined(VIDEO_HOLE)
 
 }  // namespace content