Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1026463003: Revert of Allow users to add third-party VPNs from the settings page (Closed)

Created:
5 years, 9 months ago by Dan Beam
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@f_3_460428_update_details_dialog
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow users to add third-party VPNs from the settings page (patchset #5 id:80001 of https://codereview.chromium.org/1017443002/) Reason for revert: Invalid JS caught by Closure bots: http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/18417/steps/compile/logs/stdio Original issue's description: > Allow users to add third-party VPNs from the settings page > > This CL adds "Add $provider..." entries to the "Private network" and > "Add connection" drop-down menus on the Chrome OS settings page. The > contents of these menus updates dynamically as VPN providers are > added/removed. > > BUG=460428 > TEST=Manual > > Committed: https://crrev.com/4f6e1a2ded3a56e7c2d1360b94990b025a309ecb > Cr-Commit-Position: refs/heads/master@{#321395} TBR=michaelpg@chromium.org,stevenjb@chromium.org,isherman@chromium.org,bartfab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460428 Committed: https://crrev.com/8cf549e719623e056e46715bdf2b488ea1bad09f Cr-Commit-Position: refs/heads/master@{#321402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -205 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/network_list.js View 9 chunks +34 lines, -118 lines 0 comments Download
M chrome/browser/resources/options/chromeos/vpn_providers.js View 3 chunks +2 lines, -37 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 4 chunks +6 lines, -28 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Allow users to add third-party VPNs from the settings page
5 years, 9 months ago (2015-03-19 19:03:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026463003/1
5 years, 9 months ago (2015-03-19 19:03:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 19:04:34 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 19:06:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cf549e719623e056e46715bdf2b488ea1bad09f
Cr-Commit-Position: refs/heads/master@{#321402}

Powered by Google App Engine
This is Rietveld 408576698