Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/resources/options/chromeos/vpn_providers.js

Issue 1026463003: Revert of Allow users to add third-party VPNs from the settings page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@f_3_460428_update_details_dialog
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/vpn_providers.js
diff --git a/chrome/browser/resources/options/chromeos/vpn_providers.js b/chrome/browser/resources/options/chromeos/vpn_providers.js
index 661a62c126196ecc063b6fafb2de4682c8e451b0..911c68487fbf67238d92644ad4eb93e2329bdd87 100644
--- a/chrome/browser/resources/options/chromeos/vpn_providers.js
+++ b/chrome/browser/resources/options/chromeos/vpn_providers.js
@@ -26,33 +26,6 @@
providers_: [],
/**
- * Observers who will be notified when the list of VPN providers changes.
- * @type {!Array<!function()>}
- */
- observers_: [],
-
- /**
- * The VPN providers enabled in the primary user's profile.
- * @type {!Array<{name: string, extensionID: ?string}>}
- */
- get providers() {
- return this.providers_;
- },
- set providers(providers) {
- this.providers_ = providers;
- for (var i = 0; i < this.observers_.length; ++i)
- this.observers_[i]();
- },
-
- /**
- * Adds an observer to be notified when the list of VPN providers changes.
- * @param {!function()} observer The observer to add.
- */
- addObserver: function(observer) {
- this.observers_.push(observer);
- },
-
- /**
* Formats a network name for display purposes. If the network belongs to
* a third-party VPN provider, the provider name is added to the network
* name.
@@ -77,20 +50,12 @@
};
/**
- * Adds an observer to be notified when the list of VPN providers changes.
- * @param {!function()} observer The observer to add.
- */
- VPNProviders.addObserver = function(observer) {
- VPNProviders.getInstance().addObserver(observer);
- };
-
- /**
* Returns the list of VPN providers enabled in the primary user's profile.
* @return {!Array<{name: string, extensionID: ?string}>} The list of VPN
* providers enabled in the primary user's profile.
*/
VPNProviders.getProviders = function() {
- return VPNProviders.getInstance().providers;
+ return VPNProviders.getInstance().providers_;
};
/**
@@ -99,7 +64,7 @@
* of VPN providers enabled in the primary user's profile.
*/
VPNProviders.setProviders = function(providers) {
- VPNProviders.getInstance().providers = providers;
+ VPNProviders.getInstance().providers_ = providers;
};
/**

Powered by Google App Engine
This is Rietveld 408576698