Issue 1026293002: Aggregate parameters through mappings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1026293002: Aggregate parameters through mappings. (Closed)

Created:
5 years, 9 months ago by qsr

Modified:
5 years, 9 months ago

Reviewers:
DaveMoore

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Aggregate parameters through mappings. This will allow to do something like: - Pass generic parameters to mojo:window_manager - Pass specific parameters to the final implementation It will also ensure that when mappings are present, the arguments an application receive do not depend on the URL used to connect to it the first time. This is a reland of https://codereview.chromium.org/1025603004 fixing the android tests. The arguments were not taken into account because settings arguments must happen after the context is initialized. TBR=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/acf32fb449a9ecb39c57edddfc742c9ebb683a38

Patch Set 1 #

Patch Set 2 : Fix androdi build #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -28 lines)			Patch
M	shell/android/mojo_main.cc	View	1	6 chunks	+12 lines, -7 lines	0 comments	Download
M	shell/application_manager/application_manager.h	View		5 chunks	+12 lines, -2 lines	0 comments	Download
M	shell/application_manager/application_manager.cc	View		11 chunks	+58 lines, -19 lines	0 comments	Download
M	shell/application_manager/application_manager_unittest.cc	View		1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

qsr

5 years, 9 months ago (2015-03-24 09:54:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
acf32fb449a9ecb39c57edddfc742c9ebb683a38 (presubmit successful).

Expand Messages | Collapse Messages