Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1025603004: Aggregate parameters through mappings. (Closed)

Created:
5 years, 9 months ago by qsr
Modified:
5 years, 9 months ago
Reviewers:
DaveMoore
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Aggregate parameters through mappings. This will allow to do something like: - Pass generic parameters to mojo:window_manager - Pass specific parameters to the final implementation It will also ensure that when mappings are present, the arguments an application receive do not depend on the URL used to connect to it the first time. R=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1a5952eb25c1dccb29a929542453bdaf6cdc2d42

Patch Set 1 #

Patch Set 2 : ... #

Total comments: 4

Patch Set 3 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -21 lines) Patch
M shell/application_manager/application_manager.h View 5 chunks +12 lines, -2 lines 0 comments Download
M shell/application_manager/application_manager.cc View 1 2 11 chunks +58 lines, -19 lines 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qsr
5 years, 9 months ago (2015-03-20 12:17:49 UTC) #1
DaveMoore
lgtm While I think this is the best thing to do, note that some applications ...
5 years, 9 months ago (2015-03-23 15:47:48 UTC) #2
qsr
On 2015/03/23 15:47:48, DaveMoore wrote: > lgtm > > While I think this is the ...
5 years, 9 months ago (2015-03-23 16:04:13 UTC) #3
qsr
https://codereview.chromium.org/1025603004/diff/20001/shell/application_manager/application_manager.cc File shell/application_manager/application_manager.cc (right): https://codereview.chromium.org/1025603004/diff/20001/shell/application_manager/application_manager.cc#newcode33 shell/application_manager/application_manager.cc:33: if (!v1.size()) { On 2015/03/23 15:47:48, DaveMoore wrote: > ...
5 years, 9 months ago (2015-03-23 16:04:38 UTC) #4
qsr
5 years, 9 months ago (2015-03-23 16:04:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1a5952eb25c1dccb29a929542453bdaf6cdc2d42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698