Issue 102603002: Enable PRESUMIT checks for ModifierOrder, ImportOrder and Trailing Whitespace.

Issue 102603002: Enable PRESUMIT checks for ModifierOrder, ImportOrder and Trailing Whitespace. (Closed)

Created:
7 years ago by aurimas (slooooooooow)

Modified:
7 years ago

Reviewers:
newt (away)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable PRESUMIT checks for ModifierOrder, ImportOrder and Trailing Whitespace. R=newt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238488

Patch Set 2 : Update order list #

Patch Set 3 : Adding more order packages #

Patch Set 4 : Adding class Javadoc rule #

Total comments: 2

Patch Set 5 : Removing additional JavadocType module #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	tools/android/checkstyle/chromium-style-5.0.xml	View	1 2 3 4	4 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

aurimas (slooooooooow)

Hey Newton, Please take a look at this change. Aurimas

7 years ago (2013-12-03 18:56:19 UTC) #1

newt (away)

lgtm. We'll have to watch how people react to requiring class-level javadocs. If people are ...

7 years ago (2013-12-03 23:31:18 UTC) #2

aurimas (slooooooooow)

https://codereview.chromium.org/102603002/diff/60001/tools/android/checkstyle/chromium-style-5.0.xml File tools/android/checkstyle/chromium-style-5.0.xml (right): https://codereview.chromium.org/102603002/diff/60001/tools/android/checkstyle/chromium-style-5.0.xml#newcode26 tools/android/checkstyle/chromium-style-5.0.xml:26: <module name="JavadocType"> On 2013/12/03 23:31:18, newt wrote: > can ...

7 years ago (2013-12-03 23:40:23 UTC) #3

aurimas (slooooooooow)

7 years ago (2013-12-03 23:56:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r238488 (presubmit successful).

Expand Messages | Collapse Messages