Enable PRESUMIT checks for ModifierOrder, ImportOrder and Trailing Whitespace.

tools/android/checkstyle/chromium-style-5.0.xml

 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
 
 <!--
   See installation instructions: https://sites.google.com/a/chromium.org/dev/checkstyle
 -->
 <module name="Checker">
   <property name="severity" value="warning"/>
   <property name="charset" value="UTF-8"/>
   <module name="TreeWalker">
     <module name="AvoidStarImport">
       <property name="severity" value="error"/>
     </module>
     <module name="IllegalCatch">
       <property name="severity" value="warning"/>
     </module>
     <module name="RedundantImport">
       <message key="import.redundant" value="Redundant import: {0}. Use :JavaImportOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/>
       <property name="severity" value="error"/>
     </module>
     <module name="UnusedImports">
       <property name="severity" value="error"/>
       <property name="processJavadoc" value="true"/>
       <message key="import.unused" value="Unused import: {0}. Use :JavaImportOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/>
     </module>
     <module name="JavadocType">

[newt (away), 2013/12/03 23:31:18]

can we remove this now?

[aurimas (slooooooooow), 2013/12/03 23:40:23]

Done.

       <property name="severity" value="warning"/>
       <property name="scope" value="protected"/>
     </module>
+    <module name="JavadocType">
+      <property name="severity" value="error"/>
+      <property name="tokens" value="INTERFACE_DEF, CLASS_DEF"/>
+      <property name="scope" value="public"/>
+      <message key="javadoc.missing" value="Public classes and interfaces require JavaDoc comments."/>
+    </module>
     <module name="JavadocMethod">
       <property name="severity" value="warning"/>
       <property name="scope" value="public"/>
       <property name="allowMissingParamTags" value="true"/>
       <property name="allowMissingPropertyJavadoc" value="true"/>
       <property name="allowMissingReturnTag" value="true"/>
       <property name="allowMissingThrowsTags" value="true"/>
     </module>
     <module name="PackageName">
       <property name="severity" value="warning"/>
@@ skipping 48 matching lines @@
       <property name="option" value="text"/>
       <metadata name="altname" value="EmptyCatchBlock"/>
     </module>
     <module name="UpperEll">
       <property name="severity" value="error"/>
     </module>
     <module name="FallThrough">
       <property name="severity" value="error"/>
       <property name="reliefPattern" value=".*"/>
     </module>
-    <module name="ModifierOrder"/>
+    <module name="ModifierOrder">
+      <property name="severity" value="error"/>
+    </module>
     <module name="WhitespaceAround">
       <property name="severity" value="error"/>
       <property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND, LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN, TYPE_EXTENSION_AND" />
       <property name="allowEmptyConstructors" value="true"/>
       <property name="allowEmptyMethods" value="true"/>
    </module>
     <module name="WhitespaceAfter">
       <property name="tokens" value="COMMA, SEMI, TYPECAST"/>
     </module>
     <module name="NoWhitespaceAfter">
       <property name="severity" value="error"/>
       <property name="tokens" value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS"/>
     </module>
     <module name="NoWhitespaceBefore">
       <property name="severity" value="error"/>
       <property name="allowLineBreaks" value="true"/>
       <property name="tokens" value="SEMI, DOT, POST_DEC, POST_INC"/>
     </module>
     <module name="NoFinalizer">
       <property name="severity" value="warning"/>
     </module>
     <module name="ParenPad">
       <property name="severity" value="warning"/>
     </module>
     <module name="ImportOrder">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="error"/>
       <message key="import.ordering" value="Wrong order for {0} import. Use :JavaImportOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/>
-      <property name="groups" value="android, com, org, java"/>
+      <property name="groups" value="android, com, dalvik, gov, junit, libcore, net, org, java, javax"/>
       <property name="ordered" value="true"/>
       <property name="option" value="top"/>
       <property name="separated" value="true"/>
     </module>
     <module name="Indentation">
       <property name="basicOffset" value="4"/>
     </module>
   </module>
   <module name="FileTabCharacter"/>
   <module name="RegexpSingleline">
     <property name="format" value="((//.*)|(\*.*))FIXME"/>
     <property name="message" value="TODO is preferred to FIXME.  e.g. &quot;TODO(johndoe):"/>
   </module>
   <module name="RegexpSingleline">
     <property name="format" value="((//.*)|(\*.*))(?&lt;!TODO\(.{0,100})(TODO[^(])|(TODO\([^)]*$)"/>
     <property name="message" value="All TODOs should be named.  e.g. &quot;TODO(johndoe):"/>
   </module>
   <module name="RegexpSingleline">
+    <property name="severity" value="error"/>
     <property name="format" value="[ \t]+$"/>
     <property name="message" value="Trailing whitespace"/>
     </module>
   <module name="RegexpHeader">
     <property name="severity" value="error"/>
     <property name="header" value="^// Copyright 20\d\d The Chromium Authors. All rights reserved.$\n^// Use of this source code is governed by a BSD-style license that can be$\n^// found in the LICENSE file.$"/>
   </module>
 </module>