Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1026023004: [turbofan] Fix loading of JSFunction from activation in case of adapter frame. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix loading of JSFunction from activation in case of adapter frame. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/ebc51674766dd5b17ebbfadf4a35c514ab638a5f Cr-Commit-Position: refs/heads/master@{#27454}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -6 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 1 chunk +4 lines, -6 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/osr-literals.js View 1 chunk +56 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/osr-literals-adapted.js View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
titzer
5 years, 9 months ago (2015-03-25 13:56:24 UTC) #1
Michael Starzinger
https://codereview.chromium.org/1026023004/diff/1/src/compiler/arm/code-generator-arm.cc File src/compiler/arm/code-generator-arm.cc (right): https://codereview.chromium.org/1026023004/diff/1/src/compiler/arm/code-generator-arm.cc#newcode876 src/compiler/arm/code-generator-arm.cc:876: __ ldr(r1, MemOperand(fp, -2 * kPointerSize)); Please use JavaScriptFrameConstants::kFunctionOffset ...
5 years, 9 months ago (2015-03-25 14:27:37 UTC) #2
titzer
https://codereview.chromium.org/1026023004/diff/1/src/compiler/arm/code-generator-arm.cc File src/compiler/arm/code-generator-arm.cc (right): https://codereview.chromium.org/1026023004/diff/1/src/compiler/arm/code-generator-arm.cc#newcode876 src/compiler/arm/code-generator-arm.cc:876: __ ldr(r1, MemOperand(fp, -2 * kPointerSize)); On 2015/03/25 14:27:37, ...
5 years, 9 months ago (2015-03-25 16:12:05 UTC) #3
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-25 16:44:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026023004/20001
5 years, 9 months ago (2015-03-25 16:45:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 17:46:09 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 17:46:34 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ebc51674766dd5b17ebbfadf4a35c514ab638a5f
Cr-Commit-Position: refs/heads/master@{#27454}

Powered by Google App Engine
This is Rietveld 408576698