src/compiler/x64/code-generator-x64.cc - Issue 1026023004: [turbofan] Fix loading of JSFunction from activation in case of adapter frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 1026023004: [turbofan] Fix loading of JSFunction from activation in case of adapter frame. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/x64/code-generator-x64.cc

diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc

index b3285dea9462547686514dcee76fb0eb57ff636f..3160734788b68d3888aa347fa31e8f8585815a74 100644

--- a/src/compiler/x64/code-generator-x64.cc

+++ b/src/compiler/x64/code-generator-x64.cc

@@ -1265,6 +1265,8 @@ void CodeGenerator::AssemblePrologue() {

// remaining stack slots.

if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --");

osr_pc_offset_ = __ pc_offset();

+ // TODO(titzer): cannot address target function == local #-1

+ __ movq(rdi, Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));

DCHECK(stack_slots >= frame()->GetOsrStackSlotCount());

stack_slots -= frame()->GetOsrStackSlotCount();

}

« no previous file with comments | « src/compiler/ppc/code-generator-ppc.cc ('k') | test/mjsunit/compiler/osr-literals.js » ('j') | no next file with comments »