Use kMIDIPropertyDisplayName instead of kMIDIPropertyName

Use kMIDIPropertyDisplayName instead of kMIDIPropertyName

From the documentation:
"Provides the Apple-recommended user-visible name for an endpoint, by combining the device and endpoint names."

This fixes the problem of port names of "Out Port 1", "Out Port 2" without a sense of the device it belongs to.

Committed: https://crrev.com/dad0c535aa48fe9cc47a5b316363e8222b2d9d83
Cr-Commit-Position: refs/heads/master@{#321974}

[Adam Goode, 2015-03-24 00:33:09]

The CQ bit was checked by agoode@chromium.org

[Adam Goode, 2015-03-24 00:33:09]

The CQ bit was unchecked by agoode@chromium.org

[Adam Goode, 2015-03-24 03:11:31]

agoode@chromium.org changed reviewers:
+ toyoshim@chromium.org

[Takashi Toyoshima, 2015-03-24 05:11:59]

https://codereview.chromium.org/1025903003/diff/1/media/midi/midi_manager_mac.cc
File media/midi/midi_manager_mac.cc (right):

https://codereview.chromium.org/1025903003/diff/1/media/midi/midi_manager_mac...
media/midi/midi_manager_mac.cc:54: result =
MIDIObjectGetStringProperty(endpoint, kMIDIPropertyDisplayName,
This is available on Core MIDI 1.5 and laters.
Can we have a fallback to use kMIDIPropertyName for the case this query fails?

I'm finding a document which Core MIDI version is used in each OS X, but could
not find it for now.

Mac OS X 10.6 or later is supporting OS X versions.
https://support.google.com/chrome/answer/95346?hl=en

If 10.6 supports Core MIDI 1.5, we do not need the fallback.

[Takashi Toyoshima, 2015-03-24 05:32:56]

https://developer.apple.com/library/mac/documentation/General/Reference/APIDi...

It looks being added at OS X 10.10. So, Core MIDI 1.5 == OS X 10.10 ?

[Takashi Toyoshima, 2015-03-24 05:43:28]

I checked CoreMIDI/MIDIServices.h.
It says OS X 10.4 and iOS 4.2 support the property.
So, lgtm without additional fallback path.

[Adam Goode, 2015-03-24 11:10:54]

The CQ bit was checked by agoode@chromium.org

[commit-bot: I haz the power, 2015-03-24 11:11:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1025903003/1

[commit-bot: I haz the power, 2015-03-24 11:34:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-24 11:34:49]

Patchset 1 (id:??) landed as
https://crrev.com/dad0c535aa48fe9cc47a5b316363e8222b2d9d83
Cr-Commit-Position: refs/heads/master@{#321974}