Use kMIDIPropertyDisplayName instead of kMIDIPropertyName

media/midi/midi_manager_mac.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/midi/midi_manager_mac.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 33 matching lines @@
     manufacturer = SysCFStringRefToUTF8(manufacturer_ref);
   } else {
     // kMIDIPropertyManufacturer is not supported in IAC driver providing
     // endpoints, and the result will be kMIDIUnknownProperty (-10835).
     DLOG(WARNING) << "Failed to get kMIDIPropertyManufacturer with status "
                   << result;
   }
 
   string name;
   CFStringRef name_ref = NULL;
-  result = MIDIObjectGetStringProperty(endpoint, kMIDIPropertyName, &name_ref);
+  result = MIDIObjectGetStringProperty(endpoint, kMIDIPropertyDisplayName,

[Takashi Toyoshima, 2015/03/24 05:11:59]

This is available on Core MIDI 1.5 and laters.
Can we have a fallback to use kMIDIPropertyName for the case this query fails?

I'm finding a document which Core MIDI version is used in each OS X, but could
not find it for now.

Mac OS X 10.6 or later is supporting OS X versions.
https://support.google.com/chrome/answer/95346?hl=en

If 10.6 supports Core MIDI 1.5, we do not need the fallback.

+                                       &name_ref);
   if (result == noErr)
     name = SysCFStringRefToUTF8(name_ref);
   else
-    DLOG(WARNING) << "Failed to get kMIDIPropertyName with status " << result;
+    DLOG(WARNING) << "Failed to get kMIDIPropertyDisplayName with status "
+                  << result;
 
   string version;
   SInt32 version_number = 0;
   result = MIDIObjectGetIntegerProperty(
       endpoint, kMIDIPropertyDriverVersion, &version_number);
   if (result == noErr) {
     version = IntToString(version_number);
   } else {
     // kMIDIPropertyDriverVersion is not supported in IAC driver providing
     // endpoints, and the result will be kMIDIUnknownProperty (-10835).
@@ skipping 283 matching lines @@
         &data[sent_size]);
     DCHECK(midi_packet);
 
     MIDISend(coremidi_output_, destination, packet_list);
   }
 
   client->AccumulateMidiBytesSent(data.size());
 }
 
 }  // namespace media