Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: Source/core/dom/CompositorProxy.h

Issue 1025893002: compositor-worker: Add mutable attributes to CompositorProxy. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/CompositorProxy.h
diff --git a/Source/core/dom/CompositorProxy.h b/Source/core/dom/CompositorProxy.h
index d1afa53078370852b7b5a27d26e213afc004d24a..f2f691fdc38fb4519f46b7c9809e75d8384fa049 100644
--- a/Source/core/dom/CompositorProxy.h
+++ b/Source/core/dom/CompositorProxy.h
@@ -6,6 +6,7 @@
#define CompositorProxy_h
#include "bindings/core/v8/ScriptWrappable.h"
+#include "core/dom/DOMMatrix.h"
#include "core/dom/Element.h"
#include "platform/heap/Handle.h"
#include "wtf/PassOwnPtr.h"
@@ -15,6 +16,7 @@
namespace blink {
+class DOMMatrix;
class ExceptionState;
class ExecutionContext;
@@ -28,25 +30,46 @@ public:
enum class Attributes {
NONE = 0,
OPACITY = 1 << 0,
- SCROLL_LEFT = 1 << 2,
- SCROLL_TOP = 1 << 3,
- TOUCH = 1 << 4,
- TRANSFORM = 1 << 5,
+ SCROLL_LEFT = 1 << 1,
+ SCROLL_TOP = 1 << 2,
+ TOUCH = 1 << 3,
+ TRANSFORM = 1 << 4,
};
- DEFINE_INLINE_TRACE() { }
+ DEFINE_INLINE_TRACE()
+ {
+ visitor->trace(m_transform);
+ }
uint64_t elementId() const { return m_elementId; }
uint32_t bitfieldsSupported() const { return m_bitfieldsSupported; }
bool supports(const String& attribute) const;
+ double opacity(ExceptionState&) const;
+ double scrollLeft(ExceptionState&) const;
+ double scrollTop(ExceptionState&) const;
+ DOMMatrix* transform(ExceptionState&) const;
+
+ void setOpacity(double, ExceptionState&);
+ void setScrollLeft(double, ExceptionState&);
+ void setScrollTop(double, ExceptionState&);
+ void setTransform(DOMMatrix*, ExceptionState&);
+
protected:
CompositorProxy(Element&, const Vector<String>& attributeArray);
CompositorProxy(uint64_t element, uint32_t attributeFlags);
private:
+ bool raiseExceptionIfNotMutable(Attributes, ExceptionState&) const;
+
const uint64_t m_elementId;
const uint32_t m_bitfieldsSupported;
+ uint32_t m_mutatedAttributes;
esprehn 2015/03/29 04:44:56 Why not set all of these to = 0 also?
sadrul 2015/03/30 16:07:45 Good point. Done.
+
+ double m_opacity = 0;
esprehn 2015/03/29 04:44:56 Is this allowed in blink C++11 style? :)
sadrul 2015/03/30 16:07:45 Oh, I hadn't considered the blink style guide. I t
+ double m_scrollLeft = 0;
+ double m_scrollTop = 0;
+ Member<DOMMatrix> m_transform;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698