compositor-worker: Add mutable attributes to CompositorProxy.

Source/core/dom/CompositorProxy.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CompositorProxy_h
 #define CompositorProxy_h
 
 #include "bindings/core/v8/ScriptWrappable.h"
+#include "core/dom/DOMMatrix.h"
 #include "core/dom/Element.h"
 #include "platform/heap/Handle.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
+class DOMMatrix;
 class ExceptionState;
 class ExecutionContext;
 
 class CompositorProxy final : public GarbageCollectedFinalized<CompositorProxy>, public ScriptWrappable {
     DEFINE_WRAPPERTYPEINFO();
 public:
     static CompositorProxy* create(ExecutionContext*, Element*, const Vector<String>& attributeArray, ExceptionState&);
     static CompositorProxy* create(uint64_t element, uint32_t attributeFlags);
     virtual ~CompositorProxy();
 
     enum class Attributes {
         NONE        = 0,
         OPACITY     = 1 << 0,
-        SCROLL_LEFT = 1 << 2,
-        SCROLL_TOP  = 1 << 3,
-        TOUCH       = 1 << 4,
-        TRANSFORM   = 1 << 5,
+        SCROLL_LEFT = 1 << 1,
+        SCROLL_TOP  = 1 << 2,
+        TOUCH       = 1 << 3,
+        TRANSFORM   = 1 << 4,
     };
 
-    DEFINE_INLINE_TRACE() { }
+    DEFINE_INLINE_TRACE()
+    {
+        visitor->trace(m_transform);
+    }
 
     uint64_t elementId() const { return m_elementId; }
     uint32_t bitfieldsSupported() const { return m_bitfieldsSupported; }
     bool supports(const String& attribute) const;
 
+    double opacity(ExceptionState&) const;
+    double scrollLeft(ExceptionState&) const;
+    double scrollTop(ExceptionState&) const;
+    DOMMatrix* transform(ExceptionState&) const;
+
+    void setOpacity(double, ExceptionState&);
+    void setScrollLeft(double, ExceptionState&);
+    void setScrollTop(double, ExceptionState&);
+    void setTransform(DOMMatrix*, ExceptionState&);
+
 protected:
     CompositorProxy(Element&, const Vector<String>& attributeArray);
     CompositorProxy(uint64_t element, uint32_t attributeFlags);
 
 private:
+    bool raiseExceptionIfNotMutable(Attributes, ExceptionState&) const;
+
     const uint64_t m_elementId;
     const uint32_t m_bitfieldsSupported;
+    uint32_t m_mutatedAttributes;

[esprehn, 2015/03/29 04:44:56]

Why not set all of these to = 0 also?

[sadrul, 2015/03/30 16:07:45]

Good point. Done.

+
+    double m_opacity = 0;

[esprehn, 2015/03/29 04:44:56]

Is this allowed in blink C++11 style? :)

[sadrul, 2015/03/30 16:07:45]

Oh, I hadn't considered the blink style guide. I took a look, and looks like
c++11 use in blink is expected to be the same as in chromium
(https://www.chromium.org/blink/coding-style#TOC-C--11-Features), and
"Non-Static Class Member Initializers" is allowed there
(https://chromium-cpp.appspot.com/).

+    double m_scrollLeft = 0;
+    double m_scrollTop = 0;
+    Member<DOMMatrix> m_transform;
 };
 
 } // namespace blink
 
 #endif // CompositorProxy_h