Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1025883002: Oilpan: revert SVG GC mixin constructor workaround. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
CC:
blink-reviews, Eric Willigers, krit, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, kouhei+svg_chromium.org, fs, Timothy Loh, dstockwell, ed+blinkwatch_opera.com, shans, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, pdr+svgwatchlist_chromium.org, Steve Block, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: revert SVG GC mixin constructor workaround. Following r191501 (http://crrev.com/980653002), the construction of a GC mixin object is safe, preventing conservative GCs from going ahead until the GC mixin object is in a valid state. With that in place, revert the workaround for SVG mixins (r188695), which restructured the mixin constructors such that they performed no heap allocations while the constructed object was in an invalid state. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -113 lines) Patch
M Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFitToViewBox.h View 1 chunk +1 line, -15 lines 0 comments Download
M Source/core/svg/SVGFitToViewBox.cpp View 1 chunk +3 lines, -11 lines 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGMPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSymbolElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTests.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/svg/SVGTests.cpp View 1 chunk +4 lines, -12 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGURIReference.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/svg/SVGURIReference.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGViewElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
sof
please take a look.
5 years, 9 months ago (2015-03-22 06:34:50 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-22 09:11:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025883002/1
5 years, 9 months ago (2015-03-22 13:58:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53650)
5 years, 9 months ago (2015-03-22 15:35:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025883002/1
5 years, 9 months ago (2015-03-22 15:52:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53663)
5 years, 9 months ago (2015-03-22 17:33:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025883002/1
5 years, 9 months ago (2015-03-22 17:44:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53679)
5 years, 9 months ago (2015-03-22 19:22:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025883002/1
5 years, 9 months ago (2015-03-22 20:47:33 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53698)
5 years, 9 months ago (2015-03-22 22:25:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025883002/1
5 years, 9 months ago (2015-03-23 02:01:53 UTC) #21
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 03:18:08 UTC) #22
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192330

Powered by Google App Engine
This is Rietveld 408576698