Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: Source/core/svg/SVGURIReference.h

Issue 1025883002: Oilpan: revert SVG GC mixin constructor workaround. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGTextPathElement.cpp ('k') | Source/core/svg/SVGURIReference.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008, 2009 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008, 2009 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 } 51 }
52 52
53 const String& hrefString() const { return m_href->currentValue()->value(); } 53 const String& hrefString() const { return m_href->currentValue()->value(); }
54 54
55 // JS API 55 // JS API
56 SVGAnimatedString* href() const { return m_href.get(); } 56 SVGAnimatedString* href() const { return m_href.get(); }
57 57
58 DECLARE_VIRTUAL_TRACE(); 58 DECLARE_VIRTUAL_TRACE();
59 59
60 protected: 60 protected:
61 SVGURIReference(); 61 explicit SVGURIReference(SVGElement*);
62
63 // FIXME: Oilpan: the construction of this mixin requires heap allocation,
64 // which cannot be safely done with Oilpan until the object that include
65 // this mixin have had its vptr initialized -- so as to be able to
66 // accurately trace the entire object should a GC strike while constructing
67 // the mixin.
68 //
69 // Try to come up with a more natural alternative and solution that doesn't
70 // require hoisting the constructor code for mixins into a separate method
71 // like initialize(). It makes construction of these heap-allocation mixins
72 // safe in the meantime, however.
73 //
74 void initialize(SVGElement*);
75 62
76 private: 63 private:
77 RefPtrWillBeMember<SVGAnimatedString> m_href; 64 RefPtrWillBeMember<SVGAnimatedString> m_href;
78 }; 65 };
79 66
80 } // namespace blink 67 } // namespace blink
81 68
82 #endif // SVGURIReference_h 69 #endif // SVGURIReference_h
OLDNEW
« no previous file with comments | « Source/core/svg/SVGTextPathElement.cpp ('k') | Source/core/svg/SVGURIReference.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698