chrome/browser/resources/extensions/extensions.html - Issue 1025703003: [Extensions Page] Fix the flicker of "No extensions" before extension data loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extensions.html

Issue 1025703003: [Extensions Page] Fix the flicker of "No extensions" before extension data loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/extensions/extensions.css ('K') | « chrome/browser/resources/extensions/extensions.css ('k') | chrome/browser/resources/extensions/extensions.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extensions.html

diff --git a/chrome/browser/resources/extensions/extensions.html b/chrome/browser/resources/extensions/extensions.html

index 3887401f1c07dc342c59dc517d22d584eba07e1b..684bf5db44316dd03c12a662e1535371decb8acc 100644

--- a/chrome/browser/resources/extensions/extensions.html

+++ b/chrome/browser/resources/extensions/extensions.html

@@ -1,5 +1,5 @@

<!doctype html>

-<html i18n-values="dir:textdirection;lang:language" class="loading">

+<html i18n-values="dir:textdirection;lang:language">

<head>

@@ -114,15 +114,15 @@

</div>

- <div id="extension-settings-list" class="empty-extension-list"></div>

- <div id="no-extensions">

+ <div id="extension-settings-list" hidden></div>

+ <div id="no-extensions" hidden>

<span id="no-extensions-message"

i18n-content="extensionSettingsNoExtensions"></span>

<span id="suggest-gallery" class="more-extensions-link"

i18n-values=".innerHTML:extensionSettingsSuggestGallery">

</span>

</div>

- <div id="footer-section">

+ <div id="footer-section" hidden>

Dan Beam 2015/03/20 23:13:27 can you put #footer-section and #extension-setting

Devlin 2015/03/21 01:07:18 Yep, done.

<a target="_blank" class="more-extensions-link"

i18n-values="href:extensionSettingsGetMoreExtensionsUrl"

i18n-content="extensionSettingsGetMoreExtensions"></a>