chrome/browser/resources/extensions/extensions.html - Issue 1025703003: [Extensions Page] Fix the flicker of "No extensions" before extension data loads

Side by Side Diff: chrome/browser/resources/extensions/extensions.html

Issue 1025703003: [Extensions Page] Fix the flicker of "No extensions" before extension data loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/extensions/extensions.css ('K') | « chrome/browser/resources/extensions/extensions.css ('k') | chrome/browser/resources/extensions/extensions.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html i18n-values="dir:textdirection;lang:language" class="loading">	2 <html i18n-values="dir:textdirection;lang:language">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5	5

6 <link rel="stylesheet" href="extensions.css">	6 <link rel="stylesheet" href="extensions.css">

7 <link rel="stylesheet" href="extension_commands_overlay.css">	7 <link rel="stylesheet" href="extension_commands_overlay.css">

8 <link rel="stylesheet" href="extension_error.css">	8 <link rel="stylesheet" href="extension_error.css">

9 <link rel="stylesheet" href="extension_error_overlay.css">	9 <link rel="stylesheet" href="extension_error_overlay.css">

10 <link rel="stylesheet" href="extension_load_error.css">	10 <link rel="stylesheet" href="extension_load_error.css">

11 <link rel="stylesheet" href="extension_options_overlay.css">	11 <link rel="stylesheet" href="extension_options_overlay.css">

12 <link rel="stylesheet" href="pack_extension_overlay.css">	12 <link rel="stylesheet" href="pack_extension_overlay.css">

(...skipping 94 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
107 <span id="apps-developer-tools-promo-text"	107 <span id="apps-developer-tools-promo-text"

108 i18n-values=".innerHTML:extensionSettingsAppsDevToolsPromoHTML">	108 i18n-values=".innerHTML:extensionSettingsAppsDevToolsPromoHTML">

109 </span>	109 </span>

110 <div id="apps-developer-tools-promo-close-wrapper">	110 <div id="apps-developer-tools-promo-close-wrapper">

111 <button i18n-values="title:extensionSettingsAppDevToolsPromoClose"	111 <button i18n-values="title:extensionSettingsAppDevToolsPromoClose"

112 class="custom-appearance close-button"></button>	112 class="custom-appearance close-button"></button>

113 </div>	113 </div>

114 </div>	114 </div>

115 </div>	115 </div>

116 <include src="extension_load_error.html">	116 <include src="extension_load_error.html">

117 <div id="extension-settings-list" class="empty-extension-list"></div>	117 <div id="extension-settings-list" hidden></div>

118 <div id="no-extensions">	118 <div id="no-extensions" hidden>

119 <span id="no-extensions-message"	119 <span id="no-extensions-message"

120 i18n-content="extensionSettingsNoExtensions"></span>	120 i18n-content="extensionSettingsNoExtensions"></span>

121 <span id="suggest-gallery" class="more-extensions-link"	121 <span id="suggest-gallery" class="more-extensions-link"

122 i18n-values=".innerHTML:extensionSettingsSuggestGallery">	122 i18n-values=".innerHTML:extensionSettingsSuggestGallery">

123 </span>	123 </span>

124 </div>	124 </div>

125 <div id="footer-section">	125 <div id="footer-section" hidden>
	Dan Beam 2015/03/20 23:13:27 can you put #footer-section and #extension-setting can you put #footer-section and #extension-settings-list in a wrapper and just hide that wrapper? Devlin 2015/03/21 01:07:18 Yep, done. Show quoted text On 2015/03/20 23:13:27, Dan Beam wrote: > can you put #footer-section and #extension-settings-list in a wrapper and just > hide that wrapper? Yep, done.
126 <a target="_blank" class="more-extensions-link"	126 <a target="_blank" class="more-extensions-link"

127 i18n-values="href:extensionSettingsGetMoreExtensionsUrl"	127 i18n-values="href:extensionSettingsGetMoreExtensionsUrl"

128 i18n-content="extensionSettingsGetMoreExtensions"></a>	128 i18n-content="extensionSettingsGetMoreExtensions"></a>

129 <a is="action-link" class="extension-commands-config"	129 <a is="action-link" class="extension-commands-config"

130 i18n-content="extensionSettingsCommandsLink" hidden></a>	130 i18n-content="extensionSettingsCommandsLink" hidden></a>

131 </div>	131 </div>

132 </div>	132 </div>

133	133

134 <span id="font-measuring-div"></span>	134 <span id="font-measuring-div"></span>

135	135

(...skipping 133 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
269 <include src="../../../../ui/webui/resources/html/trash.html">	269 <include src="../../../../ui/webui/resources/html/trash.html">

270 <include src="extension_error.html">	270 <include src="extension_error.html">

271	271

272 </div>	272 </div>

273	273

274 <script src="chrome://extensions-frame/strings.js"></script>	274 <script src="chrome://extensions-frame/strings.js"></script>

275 <script src="chrome://resources/js/i18n_template2.js"></script>	275 <script src="chrome://resources/js/i18n_template2.js"></script>

276	276

277 </body>	277 </body>

278 </html>	278 </html>

OLD	NEW