Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 102563004: Zonify types in compiler frontend (Closed)

Created:
7 years ago by rossberg
Modified:
6 years, 11 months ago
Reviewers:
titzer, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Zonify types in compiler frontend Clean up some zone/isolate handling in AST and its visitors on the way. (Based on https://codereview.chromium.org/103743004/) R=jkummerow@chromium.org, titzer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18719

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+639 lines, -644 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/ast.h View 1 96 chunks +227 lines, -216 lines 0 comments Download
M src/ast.cc View 1 6 chunks +17 lines, -18 lines 0 comments Download
M src/code-stubs.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +13 lines, -17 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M src/codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects.h View 6 chunks +13 lines, -15 lines 0 comments Download
M src/full-codegen.h View 4 chunks +3 lines, -7 lines 0 comments Download
M src/full-codegen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
M src/hydrogen.cc View 1 18 chunks +36 lines, -38 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/ic.h View 1 8 chunks +26 lines, -25 lines 0 comments Download
M src/ic.cc View 1 13 chunks +56 lines, -53 lines 0 comments Download
M src/ic-inl.h View 3 chunks +12 lines, -12 lines 0 comments Download
M src/list.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/objects.cc View 1 2 chunks +12 lines, -12 lines 0 comments Download
M src/parser.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/parser.cc View 6 chunks +8 lines, -10 lines 0 comments Download
M src/prettyprinter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/prettyprinter.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/property-details.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/rewriter.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/stub-cache.h View 11 chunks +19 lines, -19 lines 0 comments Download
M src/stub-cache.cc View 1 15 chunks +20 lines, -20 lines 0 comments Download
M src/type-info.h View 1 3 chunks +8 lines, -10 lines 0 comments Download
M src/type-info.cc View 1 12 chunks +26 lines, -28 lines 0 comments Download
M src/types.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/types.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/typing.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/typing.cc View 1 18 chunks +39 lines, -37 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-types.cc View 3 chunks +26 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
7 years ago (2013-12-19 17:29:44 UTC) #1
Jakob Kummerow
lgtm
7 years ago (2013-12-20 13:39:00 UTC) #2
titzer
On 2013/12/20 13:39:00, Jakob wrote: > lgtm lgtm
6 years, 11 months ago (2014-01-07 09:18:16 UTC) #3
rossberg
6 years, 11 months ago (2014-01-21 16:23:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r18719 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698