PCHECK when closing UDP sockets only when errno=EBADF.

net/udp/udp_socket_libevent.cc

Index: net/udp/udp_socket_libevent.cc
diff --git a/net/udp/udp_socket_libevent.cc b/net/udp/udp_socket_libevent.cc
index 6fdb94e5eb15e69de304145860163de27489388e..ceb1ad3e0b9c7964d977fcdfebff2920725b5bb3 100644
--- a/net/udp/udp_socket_libevent.cc
+++ b/net/udp/udp_socket_libevent.cc
@@ -126,7 +126,8 @@ void UDPSocketLibevent::Close() {
   ok = write_socket_watcher_.StopWatchingFileDescriptor();
   DCHECK(ok);
 
-  PCHECK(0 == IGNORE_EINTR(close(socket_)));
+  if (IGNORE_EINTR(close(socket_)) == -1)
+    PCHECK(errno != EBADF);

[rvargas (doing something else), 2015/03/19 22:34:05]

How about filtering by EIO instead and leaving errno on the stack (although that
is almost pointless as getting it out of a dump on mac is going to be a pain).

[Sergey Ulanov, 2015/03/19 22:53:35]

Done.

 
   socket_ = kInvalidSocket;
   addr_family_ = 0;