PCHECK when closing UDP sockets only when errno=EBADF.

net/udp/udp_socket_libevent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/udp/udp_socket_libevent.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <netdb.h>
 #include <net/if.h>
@@ skipping 108 matching lines @@
   write_buf_ = NULL;
   write_buf_len_ = 0;
   write_callback_.Reset();
   send_to_address_.reset();
 
   bool ok = read_socket_watcher_.StopWatchingFileDescriptor();
   DCHECK(ok);
   ok = write_socket_watcher_.StopWatchingFileDescriptor();
   DCHECK(ok);
 
-  PCHECK(0 == IGNORE_EINTR(close(socket_)));
+  if (IGNORE_EINTR(close(socket_)) == -1)
+    PCHECK(errno != EBADF);

[rvargas (doing something else), 2015/03/19 22:34:05]

How about filtering by EIO instead and leaving errno on the stack (although that
is almost pointless as getting it out of a dump on mac is going to be a pain).

[Sergey Ulanov, 2015/03/19 22:53:35]

Done.

 
   socket_ = kInvalidSocket;
   addr_family_ = 0;
   is_connected_ = false;
 }
 
 int UDPSocketLibevent::GetPeerAddress(IPEndPoint* address) const {
   DCHECK(CalledOnValidThread());
   DCHECK(address);
   if (!is_connected())
@@ skipping 603 matching lines @@
     return MapSystemError(errno);
 
   return OK;
 }
 
 void UDPSocketLibevent::DetachFromThread() {
   base::NonThreadSafe::DetachFromThread();
 }
 
 }  // namespace net