gpu/command_buffer/tests/gl_manager.cc - Issue 1025523005: gl_tests: Use zero size gl surface for offscreen rendering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/tests/gl_manager.cc

Issue 1025523005: gl_tests: Use zero size gl surface for offscreen rendering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make gpu_unittests pass as well Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/client/cmd_buffer_helper_test.cc ('K') | « gpu/command_buffer/service/gpu_scheduler_unittest.cc ('k') | gpu/command_buffer/tests/gl_tests_main.cc » ('j') | gpu/command_buffer/tests/gl_tests_main.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/tests/gl_manager.cc

diff --git a/gpu/command_buffer/tests/gl_manager.cc b/gpu/command_buffer/tests/gl_manager.cc

index 4e4eccb2abed4026fc23ec1c918f52a9f3af8d74..2ae68ad5d2a2cad511dc128bfce58544430adfe3 100644

--- a/gpu/command_buffer/tests/gl_manager.cc

+++ b/gpu/command_buffer/tests/gl_manager.cc

@@ -232,7 +232,7 @@ void GLManager::InitializeWithCommandLine(const GLManager::Options& options,

decoder_->set_engine(gpu_scheduler_.get());

- surface_ = gfx::GLSurface::CreateOffscreenGLSurface(options.size);

+ surface_ = gfx::GLSurface::CreateOffscreenGLSurface(gfx::Size());

ASSERT_TRUE(surface_.get() != NULL) << "could not create offscreen surface";

if (base_context_) {