DescriptionMIPS64: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily
Port 6689cc27ebe60685c025de9ae1f09919093f8213
Original commit message:
Handlers should be in charge of this work. The change uncovered a bug in
vector-ics related to keyed loads into strings. It's important for
StringCharCodeAtGenerator, a helper used in full code and in
LoadIndexedStringStub (a handler) to protect the vector and slot registers
when it makes a runtime call to convert a HeapNumber to a Smi.
It's still possible for the handler to MISS after this call, perhaps due
to out of bounds access. In that case, the vector and slot registers need
to be delivered safely to the MISS handler.
BUG=
Committed: https://crrev.com/fe0d860ba8e045080bef466d1611ec5ffdbf8498
Cr-Commit-Position: refs/heads/master@{#27383}
Patch Set 1 #
Messages
Total messages: 8 (2 generated)
|