Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1025303005: MIPS64: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily (Closed)

Created:
5 years, 9 months ago by akos.palfi.imgtec
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily Port 6689cc27ebe60685c025de9ae1f09919093f8213 Original commit message: Handlers should be in charge of this work. The change uncovered a bug in vector-ics related to keyed loads into strings. It's important for StringCharCodeAtGenerator, a helper used in full code and in LoadIndexedStringStub (a handler) to protect the vector and slot registers when it makes a runtime call to convert a HeapNumber to a Smi. It's still possible for the handler to MISS after this call, perhaps due to out of bounds access. In that case, the vector and slot registers need to be delivered safely to the MISS handler. BUG= Committed: https://crrev.com/fe0d860ba8e045080bef466d1611ec5ffdbf8498 Cr-Commit-Position: refs/heads/master@{#27383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M src/mips64/code-stubs-mips64.cc View 5 chunks +15 lines, -9 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
akos.palfi.imgtec
PTAL.
5 years, 9 months ago (2015-03-23 20:58:47 UTC) #2
mvstanton
LGTM, thanks for the port!
5 years, 9 months ago (2015-03-23 21:04:13 UTC) #3
paul.l...
Also LGTM. Thanks for the review & the mips32 port Michael!
5 years, 9 months ago (2015-03-23 21:06:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025303005/1
5 years, 9 months ago (2015-03-23 21:42:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 22:45:11 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 22:45:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe0d860ba8e045080bef466d1611ec5ffdbf8498
Cr-Commit-Position: refs/heads/master@{#27383}

Powered by Google App Engine
This is Rietveld 408576698