Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: src/mips64/full-codegen-mips64.cc

Issue 1025303005: MIPS64: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/code-stubs-mips64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 4093 matching lines...) Expand 10 before | Expand all | Expand 10 after
4104 __ LoadRoot(result, Heap::kNanValueRootIndex); 4104 __ LoadRoot(result, Heap::kNanValueRootIndex);
4105 __ jmp(&done); 4105 __ jmp(&done);
4106 4106
4107 __ bind(&need_conversion); 4107 __ bind(&need_conversion);
4108 // Load the undefined value into the result register, which will 4108 // Load the undefined value into the result register, which will
4109 // trigger conversion. 4109 // trigger conversion.
4110 __ LoadRoot(result, Heap::kUndefinedValueRootIndex); 4110 __ LoadRoot(result, Heap::kUndefinedValueRootIndex);
4111 __ jmp(&done); 4111 __ jmp(&done);
4112 4112
4113 NopRuntimeCallHelper call_helper; 4113 NopRuntimeCallHelper call_helper;
4114 generator.GenerateSlow(masm_, call_helper); 4114 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4115 4115
4116 __ bind(&done); 4116 __ bind(&done);
4117 context()->Plug(result); 4117 context()->Plug(result);
4118 } 4118 }
4119 4119
4120 4120
4121 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) { 4121 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) {
4122 ZoneList<Expression*>* args = expr->arguments(); 4122 ZoneList<Expression*>* args = expr->arguments();
4123 DCHECK(args->length() == 2); 4123 DCHECK(args->length() == 2);
4124 4124
(...skipping 28 matching lines...) Expand all
4153 __ LoadRoot(result, Heap::kempty_stringRootIndex); 4153 __ LoadRoot(result, Heap::kempty_stringRootIndex);
4154 __ jmp(&done); 4154 __ jmp(&done);
4155 4155
4156 __ bind(&need_conversion); 4156 __ bind(&need_conversion);
4157 // Move smi zero into the result register, which will trigger 4157 // Move smi zero into the result register, which will trigger
4158 // conversion. 4158 // conversion.
4159 __ li(result, Operand(Smi::FromInt(0))); 4159 __ li(result, Operand(Smi::FromInt(0)));
4160 __ jmp(&done); 4160 __ jmp(&done);
4161 4161
4162 NopRuntimeCallHelper call_helper; 4162 NopRuntimeCallHelper call_helper;
4163 generator.GenerateSlow(masm_, call_helper); 4163 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4164 4164
4165 __ bind(&done); 4165 __ bind(&done);
4166 context()->Plug(result); 4166 context()->Plug(result);
4167 } 4167 }
4168 4168
4169 4169
4170 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 4170 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
4171 ZoneList<Expression*>* args = expr->arguments(); 4171 ZoneList<Expression*>* args = expr->arguments();
4172 DCHECK_EQ(2, args->length()); 4172 DCHECK_EQ(2, args->length());
4173 VisitForStackValue(args->at(0)); 4173 VisitForStackValue(args->at(0));
(...skipping 1294 matching lines...) Expand 10 before | Expand all | Expand 10 after
5468 Assembler::target_address_at(pc_immediate_load_address)) == 5468 Assembler::target_address_at(pc_immediate_load_address)) ==
5469 reinterpret_cast<uint64_t>( 5469 reinterpret_cast<uint64_t>(
5470 isolate->builtins()->OsrAfterStackCheck()->entry())); 5470 isolate->builtins()->OsrAfterStackCheck()->entry()));
5471 return OSR_AFTER_STACK_CHECK; 5471 return OSR_AFTER_STACK_CHECK;
5472 } 5472 }
5473 5473
5474 5474
5475 } } // namespace v8::internal 5475 } } // namespace v8::internal
5476 5476
5477 #endif // V8_TARGET_ARCH_MIPS64 5477 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips64/code-stubs-mips64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698