Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1025103002: Merging to M42 (Closed)

Created:
5 years, 9 months ago by ananta
Modified:
5 years, 9 months ago
CC:
chromium-reviews, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Merging to M42 Add Segoe UI and its set of linked fonts to the font back list on Windows. This is to attempt to fallback to a font which could help render text on Windows installations where the default font is a raster font like System, etc. Segoe UI provides fallbacks for Korean, Japanese, Chinese, Armenian, etc. While this would not cover all cases, it is a reasonable addition. BUG=467459 TEST=Install Windows 7 Korean edition. Change the system font to system. Run Chrome without this fix. Navigate to some korean websites. Observe that the tab title shows up empty. With this fix the title should render correctly. Review URL: https://codereview.chromium.org/1009533003 TBR=msw Cr-Commit-Position: refs/heads/master@{#321077} (cherry picked from commit 4ceae8dcde9e2f60577681fe747bbbb7ce017d3d) Committed: https://chromium.googlesource.com/chromium/src/+/82b677007209a0e2e1a21599a6c316327488a112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/gfx/render_text_harfbuzz.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ananta
5 years, 9 months ago (2015-03-21 01:36:49 UTC) #2
ananta
Committed patchset #1 (id:1) manually as 82b677007209a0e2e1a21599a6c316327488a112 (presubmit successful).
5 years, 9 months ago (2015-03-21 01:39:53 UTC) #3
msw
5 years, 9 months ago (2015-03-21 02:51:56 UTC) #5
Message was sent while issue was closed.
+asvitkine and scottmg, who actually approved the original patch.
I'm disappointed that the underlying defect was never uncovered, and this had
little time to bake on Canary before merging to stable, but I suppose this is a
reasonable workaround for now... I hope we'll find a better mid-/long-term fix.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698