Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 1025103002: Merging to M42 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2311
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.cc
diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc
index 0580abe3375e09bddae437c08a958ee6a7d16977..1083def6baebc12a423681ad420a41ee82198ccd 100644
--- a/ui/gfx/render_text_harfbuzz.cc
+++ b/ui/gfx/render_text_harfbuzz.cc
@@ -1255,6 +1255,16 @@ void RenderTextHarfBuzz::ShapeRun(const base::string16& text,
fallback_families.insert(fallback_families.end(),
uniscribe_fallbacks.begin(), uniscribe_fallbacks.end());
}
+
+ // Add Segoe UI and its associated linked fonts to the fallback font list to
+ // ensure that the fallback list covers the basic cases.
+ // http://crbug.com/467459. On some Windows configurations the default font
+ // could be a raster font like System, which would not give us a reasonable
+ // fallback font list.
+ std::vector<std::string> default_fallback_families =
+ GetFallbackFontFamilies("Segoe UI");
+ fallback_families.insert(fallback_families.end(),
+ default_fallback_families.begin(), default_fallback_families.end());
#endif
// Try shaping with the fallback fonts.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698