Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issue 1025013003: Move dom-serializer.sky to dom_serializer.dart (and clean up some analyizer errors) (Closed)

Created:
5 years, 9 months ago by rafaelw
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move dom-serializer.sky to dom_serializer.dart (and clean up some analyizer errors) TBR=abarth Committed: https://chromium.googlesource.com/external/mojo/+/19353ef0762982d1c597143a8771282bb83970ca

Patch Set 1 #

Patch Set 2 : foo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -121 lines) Patch
M sky/tests/TestExpectations View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/resources/dom-serializer.sky View 1 chunk +0 lines, -99 lines 0 comments Download
A + sky/tests/resources/dom_serializer.dart View 4 chunks +5 lines, -9 lines 0 comments Download
M sky/tests/resources/dump-as-markup.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
rafaelw
5 years, 9 months ago (2015-03-20 22:41:13 UTC) #2
rafaelw
Committed patchset #2 (id:20001) manually as 19353ef0762982d1c597143a8771282bb83970ca (presubmit successful).
5 years, 9 months ago (2015-03-20 22:42:45 UTC) #3
abarth-chromium
5 years, 9 months ago (2015-03-20 22:43:03 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698