Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: sky/tests/resources/dom_serializer.dart

Issue 1025013003: Move dom-serializer.sky to dom_serializer.dart (and clean up some analyizer errors) (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: foo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tests/resources/dom-serializer.sky ('k') | sky/tests/resources/dump-as-markup.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tests/resources/dom_serializer.dart
diff --git a/sky/tests/resources/dom-serializer.sky b/sky/tests/resources/dom_serializer.dart
similarity index 92%
rename from sky/tests/resources/dom-serializer.sky
rename to sky/tests/resources/dom_serializer.dart
index f63f05841501bfa9ee570763d8cf3664d7df7574..d0ebe87f6251fd8e3a0b4023bda57c0a8b1ccc70 100644
--- a/sky/tests/resources/dom-serializer.sky
+++ b/sky/tests/resources/dom_serializer.dart
@@ -1,9 +1,6 @@
-<!--
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
--->
-<script>
import "dart:sky";
final kEntityMap = new Map.fromIterable([
@@ -42,19 +39,19 @@ String serializeAttributes(Element element) {
return buffer;
}
-Node getFirstChild(Node node) {
+Node getFirstChild(ParentNode node) {
if (node is HTMLTemplateElement)
return node.content.firstChild;
return node.firstChild;
}
-Node getLastChild(Node node) {
+Node getLastChild(ParentNode node) {
if (node is HTMLTemplateElement)
return node.content.lastChild;
return node.lastChild;
}
-String serializeChildren(Node node, int depth) {
+String serializeChildren(ParentNode node, int depth) {
String buffer = '';
Node firstChild = getFirstChild(node);
Node lastChild = getLastChild(node);
@@ -80,7 +77,7 @@ String serializeElement(Element element, int depth) {
return buffer;
}
-String serializeText(Node node) {
+String serializeText(Text node) {
Node parent = node.parentNode;
if (parent != null && (parent is HTMLScriptElement || parent is HTMLStyleElement))
return node.data;
@@ -94,6 +91,5 @@ String serializeNode(Node node, [int depth = 0]) {
return serializeElement(node, depth);
if (node is Document || node is ShadowRoot)
return serializeChildren(node, depth);
- throw new Error('Cannot serialize node');
+ throw new Exception('Cannot serialize node');
}
-</script>
« no previous file with comments | « sky/tests/resources/dom-serializer.sky ('k') | sky/tests/resources/dump-as-markup.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698