Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1024633003: operator overloads for Sk4x, use them all where possible (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

operator overloads for Sk4x, use them all where possible BUG=skia: NOTRY=true Committed: https://skia.googlesource.com/skia/+/26bf90e5d63024585a8261b224ea4387079e2751

Patch Set 1 #

Patch Set 2 : weird, msvc doesnt like operator~() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -27 lines) Patch
M src/core/Sk4x.h View 1 2 chunks +23 lines, -0 lines 0 comments Download
M tests/PMFloatTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Sk2xTest.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M tests/Sk4xTest.cpp View 1 2 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
mtklein_C
5 years, 9 months ago (2015-03-19 21:57:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024633003/1
5 years, 9 months ago (2015-03-19 21:58:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-19 21:58:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/3047) Build-Win-VS2013-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 9 months ago (2015-03-19 22:01:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024633003/20001
5 years, 9 months ago (2015-03-19 22:07:43 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-19 22:07:44 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-20 04:07:57 UTC) #12
caryclark
lgtm
5 years, 9 months ago (2015-03-20 11:36:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024633003/20001
5 years, 9 months ago (2015-03-20 11:40:28 UTC) #15
rmistry
On 2015/03/20 11:40:28, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 9 months ago (2015-03-20 12:32:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024633003/20001
5 years, 9 months ago (2015-03-20 12:32:31 UTC) #19
rmistry
On 2015/03/20 12:32:31, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 9 months ago (2015-03-20 12:33:41 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024633003/20001
5 years, 9 months ago (2015-03-20 12:34:32 UTC) #23
mtklein
On 2015/03/20 12:33:41, rmistry wrote: > On 2015/03/20 12:32:31, I haz the power (commit-bot) wrote: ...
5 years, 9 months ago (2015-03-20 12:35:15 UTC) #24
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 13:01:05 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/26bf90e5d63024585a8261b224ea4387079e2751

Powered by Google App Engine
This is Rietveld 408576698