Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: Source/core/frame/FrameDestructionObserver.h

Issue 1024543004: Disallow adding ContextLifecycleObservers during iteration. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tidier LifecycleObserver ctor Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/DOMWindowLifecycleObserver.cpp ('k') | Source/core/frame/FrameDestructionObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameDestructionObserver.h
diff --git a/Source/core/frame/FrameDestructionObserver.h b/Source/core/frame/FrameDestructionObserver.h
index 601166c2c57603b4d2209c9b439817d9bd1b73f0..98b1403c4bab26b6a147a57b2bdef9b843d01cd3 100644
--- a/Source/core/frame/FrameDestructionObserver.h
+++ b/Source/core/frame/FrameDestructionObserver.h
@@ -38,7 +38,7 @@ class LocalFrameLifecycleNotifier;
class CORE_EXPORT FrameDestructionObserver : public LifecycleObserver<LocalFrame, FrameDestructionObserver, LocalFrameLifecycleNotifier> {
public:
- virtual void willDetachFrameHost();
+ virtual void willDetachFrameHost() { }
virtual void contextDestroyed()
{
setContext(nullptr);
@@ -47,7 +47,10 @@ public:
LocalFrame* frame() const { return lifecycleContext(); }
protected:
- explicit FrameDestructionObserver(LocalFrame*);
+ explicit FrameDestructionObserver(LocalFrame* frame)
+ : LifecycleObserver(frame)
+ {
+ }
};
} // namespace blink
« no previous file with comments | « Source/core/frame/DOMWindowLifecycleObserver.cpp ('k') | Source/core/frame/FrameDestructionObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698