Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: Source/core/frame/FrameDestructionObserver.h

Issue 1024543004: Disallow adding ContextLifecycleObservers during iteration. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tidier LifecycleObserver ctor Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2011 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 20 matching lines...) Expand all
31 #include "platform/LifecycleObserver.h" 31 #include "platform/LifecycleObserver.h"
32 #include "platform/heap/Handle.h" 32 #include "platform/heap/Handle.h"
33 33
34 namespace blink { 34 namespace blink {
35 35
36 class LocalFrame; 36 class LocalFrame;
37 class LocalFrameLifecycleNotifier; 37 class LocalFrameLifecycleNotifier;
38 38
39 class CORE_EXPORT FrameDestructionObserver : public LifecycleObserver<LocalFrame , FrameDestructionObserver, LocalFrameLifecycleNotifier> { 39 class CORE_EXPORT FrameDestructionObserver : public LifecycleObserver<LocalFrame , FrameDestructionObserver, LocalFrameLifecycleNotifier> {
40 public: 40 public:
41 virtual void willDetachFrameHost(); 41 virtual void willDetachFrameHost() { }
42 virtual void contextDestroyed() 42 virtual void contextDestroyed()
43 { 43 {
44 setContext(nullptr); 44 setContext(nullptr);
45 } 45 }
46 46
47 LocalFrame* frame() const { return lifecycleContext(); } 47 LocalFrame* frame() const { return lifecycleContext(); }
48 48
49 protected: 49 protected:
50 explicit FrameDestructionObserver(LocalFrame*); 50 explicit FrameDestructionObserver(LocalFrame* frame)
51 : LifecycleObserver(frame)
52 {
53 }
51 }; 54 };
52 55
53 } // namespace blink 56 } // namespace blink
54 57
55 #endif // FrameDestructionObserver_h 58 #endif // FrameDestructionObserver_h
OLDNEW
« no previous file with comments | « Source/core/frame/DOMWindowLifecycleObserver.cpp ('k') | Source/core/frame/FrameDestructionObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698