Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 1024543002: Rename kMaxFrameRenderingIdleTime to kMaxActiveIdleTime and adjust it to the currently maximum valu… (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename kMaxFrameRenderingIdleTime to kMaxActiveIdleTime and adjust it to the currently maximum value of 50ms passed in by the Blink scheduler. BUG=468692 LOG=n Committed: https://crrev.com/597992522d1323a8afbeb8435c3cec9b1e3f4cc5 Cr-Commit-Position: refs/heads/master@{#27321}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Hannes Payer (out of office)
5 years, 9 months ago (2015-03-19 15:39:06 UTC) #2
rmcilroy
lgtm, thanks! https://codereview.chromium.org/1024543002/diff/1/src/heap/gc-idle-time-handler.h File src/heap/gc-idle-time-handler.h (right): https://codereview.chromium.org/1024543002/diff/1/src/heap/gc-idle-time-handler.h#newcode125 src/heap/gc-idle-time-handler.h:125: // This is the maximum idle time ...
5 years, 9 months ago (2015-03-19 15:43:50 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1024543002/diff/1/src/heap/gc-idle-time-handler.h File src/heap/gc-idle-time-handler.h (right): https://codereview.chromium.org/1024543002/diff/1/src/heap/gc-idle-time-handler.h#newcode125 src/heap/gc-idle-time-handler.h:125: // This is the maximum idle time we will ...
5 years, 9 months ago (2015-03-19 16:03:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024543002/20001
5 years, 9 months ago (2015-03-19 16:03:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 19:41:07 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 19:41:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/597992522d1323a8afbeb8435c3cec9b1e3f4cc5
Cr-Commit-Position: refs/heads/master@{#27321}

Powered by Google App Engine
This is Rietveld 408576698