Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1024533002: Reland of: Profile_Metrics integration with Keystone (Closed)

Created:
5 years, 9 months ago by Mike Lerman
Modified:
5 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of: Profile_Metrics integration with Keystone Chromium side of the implementation of tracking profile stats (number of profiles, number of signed in profiles) through the Omaha channel for Mac. Was reverted: https://codereview.chromium.org/974423002 BUG=409895 TBR=grt@chromium.org Committed: https://crrev.com/1e9f61ce03c1d2862e154cfd46c10859d00fb755 Cr-Commit-Position: refs/heads/master@{#321807}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -19 lines) Patch
M chrome/browser/mac/keystone_glue.h View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/mac/keystone_glue.mm View 6 chunks +56 lines, -4 lines 0 comments Download
M chrome/browser/mac/keystone_glue_unittest.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/mac/keystone_registration.h View 2 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/mac/keystone_registration.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_metrics.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_metrics.cc View 1 2 6 chunks +18 lines, -8 lines 0 comments Download
A chrome/browser/profiles/profile_metrics_mac.mm View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/google_update_settings.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.cc View 5 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike Lerman
Hi Mark, I have approval to land this again. I think the only reason it ...
5 years, 9 months ago (2015-03-19 20:10:31 UTC) #2
Mark Mentovai
LGTM. Go for it. Good luck.
5 years, 9 months ago (2015-03-19 22:05:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024533002/40001
5 years, 9 months ago (2015-03-23 17:03:23 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-23 18:14:14 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 18:15:09 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1e9f61ce03c1d2862e154cfd46c10859d00fb755
Cr-Commit-Position: refs/heads/master@{#321807}

Powered by Google App Engine
This is Rietveld 408576698