Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 974423002: Revert of Profile_Metrics integration with Keystone (Closed)

Created:
5 years, 9 months ago by Mike Lerman
Modified:
5 years, 9 months ago
CC:
chromium-reviews, borisv
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Profile_Metrics integration with Keystone (patchset #20 id:530001 of https://codereview.chromium.org/593243002/) Reason for revert: crbug.com/463900. Mac crashed, like, all the time. Original issue's description: > Profile_Metrics integration with Keystone > > Chromium side of the implementation of tracking profile stats (number of profiles, number of signed in profiles) through the Omaha channel for Mac. Design doc: https://docs.google.com/a/google.com/document/d/15Ou8VCYNCZvke8Bw9bF3vYqD67voJBPyx_GBR8ONcCw/edit?disco=AAAAAKU7Zzg (Googler Only) > > BUG=409895 > > Committed: https://crrev.com/0bcaa8e521eae39a81b4754f8b4ac9de1f0463d5 > Cr-Commit-Position: refs/heads/master@{#318729} TBR=bcwhite@chromium.org,borisv@chromium.org,mark@chromium.org,grt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=409895 Committed: https://crrev.com/41c1eeb5fa7f3356860d9c00afa547d10e26b79d Cr-Commit-Position: refs/heads/master@{#319125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -158 lines) Patch
M chrome/browser/mac/keystone_glue.h View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/mac/keystone_glue.mm View 6 chunks +4 lines, -56 lines 0 comments Download
M chrome/browser/mac/keystone_glue_unittest.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/mac/keystone_registration.h View 2 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/mac/keystone_registration.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_metrics.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_metrics.cc View 5 chunks +8 lines, -18 lines 0 comments Download
D chrome/browser/profiles/profile_metrics_mac.mm View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/util/google_update_settings.cc View 5 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Lerman
Created Revert of Profile_Metrics integration with Keystone
5 years, 9 months ago (2015-03-04 21:02:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974423002/1
5 years, 9 months ago (2015-03-04 21:03:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 21:04:49 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 21:05:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41c1eeb5fa7f3356860d9c00afa547d10e26b79d
Cr-Commit-Position: refs/heads/master@{#319125}

Powered by Google App Engine
This is Rietveld 408576698