Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: Source/core/animation/StringKeyframe.cpp

Issue 1024473004: Do not treat '0' as 'none' for font-size-adjust (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/StringKeyframe.cpp
diff --git a/Source/core/animation/StringKeyframe.cpp b/Source/core/animation/StringKeyframe.cpp
index d6cee7153764a3142e72e852c806202ea154a410..0c07ab2719d43f8b36a1ad16d39c4fe10a5d270f 100644
--- a/Source/core/animation/StringKeyframe.cpp
+++ b/Source/core/animation/StringKeyframe.cpp
@@ -216,10 +216,6 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::
fallBackToLegacy = true;
break;
- case CSSPropertyFontSizeAdjust:
- // FIXME: Requires special handing for 0.
- fallBackToLegacy = true;
- break;
case CSSPropertyOrphans:
case CSSPropertyWidows:
case CSSPropertyZIndex:
@@ -227,12 +223,17 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::
case CSSPropertyShapeImageThreshold:
case CSSPropertyFillOpacity:
case CSSPropertyFloodOpacity:
+ case CSSPropertyFontSizeAdjust:
case CSSPropertyOpacity:
case CSSPropertyStopOpacity:
case CSSPropertyStrokeOpacity:
case CSSPropertyStrokeMiterlimit:
if (DoubleStyleInterpolation::canCreateFrom(*fromCSSValue) && DoubleStyleInterpolation::canCreateFrom(*toCSSValue))
return DoubleStyleInterpolation::create(*fromCSSValue, *toCSSValue, property, toCSSPrimitiveValue(fromCSSValue)->primitiveType(), setRange(property));
+
+ // FIXME: Handle keywords e.g. 'none'.
dstockwell 2015/03/20 03:24:29 This shouldn't be necessary now. Does anything bre
changseok 2015/03/20 08:29:39 Nothing. Removed.
+ if (property == CSSPropertyFontSizeAdjust)
+ fallBackToLegacy = true;
break;
case CSSPropertyMotionRotation: {

Powered by Google App Engine
This is Rietveld 408576698