Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1024373002: Remove app_crash_browsertest.cc. (Closed)

Created:
5 years, 9 months ago by jackhou1
Modified:
5 years, 9 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove app_crash_browsertest.cc. This is effectively a revert of https://codereview.chromium.org/50073003 This was originally added to cover a crash in GTK, which is no longer used. These days, other app window tests will also wait for the app window to finish loading. The hidden-window plus normal-window case has been added to platform_apps/window_api. BUG=469249 Committed: https://crrev.com/8de5ce1679b9e9bf9083fff9d938fc3d4109a62b Cr-Commit-Position: refs/heads/master@{#321937}

Patch Set 1 #

Patch Set 2 : Add test to platform_apps/window_api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -55 lines) Patch
D chrome/browser/apps/app_crash_browsertest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/platform_apps/crashtest_hidden_windows/manifest.json View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/crashtest_hidden_windows/test.js View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/window_api/test.js View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
benwells, could you take a look?
5 years, 9 months ago (2015-03-23 22:19:44 UTC) #2
benwells
lgtm
5 years, 9 months ago (2015-03-24 03:26:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024373002/20001
5 years, 9 months ago (2015-03-24 03:55:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 05:16:30 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 05:17:17 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8de5ce1679b9e9bf9083fff9d938fc3d4109a62b
Cr-Commit-Position: refs/heads/master@{#321937}

Powered by Google App Engine
This is Rietveld 408576698