Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2695)

Unified Diff: chrome/common/ntp_logging_events.h

Issue 102433009: Most visited iframe now postMessage to signal the iframing page that the link has been displayed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed support for multiple thumbnail URLs, refactored UMA logging. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/ntp_logging_events.h
diff --git a/chrome/common/ntp_logging_events.h b/chrome/common/ntp_logging_events.h
index ebb213a1e5eac3de1bf4f9cb350f8d1f822aea19..f3253b4ee14702774fef9c601d5eeb8625068621 100644
--- a/chrome/common/ntp_logging_events.h
+++ b/chrome/common/ntp_logging_events.h
@@ -17,13 +17,8 @@ enum NTPLoggingEventType {
// (if it was provided), resulting in a grey tile.
NTP_THUMBNAIL_ERROR = 2,
- // The page attempted to load a thumbnail URL while a fallback thumbnail was
- // provided.
- NTP_FALLBACK_THUMBNAIL_REQUESTED = 3,
-
- // The primary thumbnail image failed to load and caused us to use the
- // secondary thumbnail as a fallback.
- NTP_FALLBACK_THUMBNAIL_USED = 4,
+ // DEPRECATED: NTP_FALLBACK_THUMBNAIL_REQUESTED = 3,
sky 2014/01/09 00:25:34 nit: Since you're commenting out the constants the
beaudoin 2014/01/15 23:39:56 Just cleaned up this whole enum. Since it's only i
+ // DEPRECATED: NTP_FALLBACK_THUMBNAIL_USED = 4,
// The suggestion is coming from the server.
NTP_SERVER_SIDE_SUGGESTION = 5,
@@ -34,6 +29,20 @@ enum NTPLoggingEventType {
// The visuals of that tile are handled externally by the page itself.
NTP_EXTERNAL_TILE = 7,
+ // Indicates a tile was rendered, no matter if it's a thumbnail, a gray tile
+ // or an external tile.
+ NTP_TILE = 8,
+
+ // Used when no thumbnail is specified and a gray tile with the domain is used
+ // as the main tile.
+ NTP_GRAY_TILE = 9,
+
+ // Used a gray tile with the domain as the fallback for a failed thumbnail.
+ NTP_GRAY_TILE_FALLBACK = 10,
+
+ // The visuals of that tile's fallback are handled externally.
+ NTP_EXTERNAL_FALLBACK = 11,
+
NTP_NUM_EVENT_TYPES
};

Powered by Google App Engine
This is Rietveld 408576698